feat: adds support for custom sources for Python distributions #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking forward to this feature desperately. |
|
Thanks! It's hard to modify infra but easy to set environment variables so I've changed it such that you can set a unique environment variable per distribution rather than having to mandate a URL scheme. |
ofek
approved these changes
May 26, 2024
ofek
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
May 26, 2024
Co-authored-by: Ofek Lev <ofekmeister@gmail.com> c84d7b3
axel-kah
deleted the
feature/adds-support-for-python-and-pypy-distribution-mirrors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #1194 .
Instead of adding another request for this feature I thought I could just contribute one possible solution. It would unlock the majority of enterprise users which have to deal with locked down compute environments. Please be gentle though, this is my first PR in a high profile repo馃槄
This feature introduces two new environment variables and does not touch the script-generated distributions.py file.
I was unable to find public mirrors for the Python/PyPy interpreter, but I could write a test which mimics a mirror by downloading some archives and host them via the built in webserver for example and pass that local host URL as a custom distribution source. Just let me know.