-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci update #1305
base: main
Are you sure you want to change the base?
ci update #1305
Conversation
This was modeled after spopt ci, for reference. |
- inequality | ||
- access | ||
- splot | ||
- pip: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we move spopt
into the dependencies
section (in all environments)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gentle ping to remind to remove the pip: spopt
and move spopt
directly up beneath splot
in an CI environments for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the -oldest
tag we should ideally have minimum pins. We could probably simply follow SPEC000 for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a bit tricky to do in here as you would need to pin 2nd order dependencies, given the pysal depends only on subpackages, where we always want to pull the latest, never the oldest. I would probably leave this env out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sjsrey If we follow @martinfleis's idea here, we can simply rename 310-oldest.yaml
--> 310-latest.yaml
(and in the workflow file) and have done with it.
Co-authored-by: James Gaboardi <jgaboardi@gmail.com>
Co-authored-by: Martin Fleischmann <martin@martinfleischmann.net>
Looks like
|
re: pacakage install For some packages (e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file still even needed? I opened #1306 because I thought it could be pruned entirely.
Addressing #1299