Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement an OIDC-based backend for uc-cdis/fence #341

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

VJalili
Copy link
Contributor

@VJalili VJalili commented Mar 27, 2019

Fence repo: https://github.com/uc-cdis/fence

TODOs:

  • Fence does not support nonce (see Include nonce claim in the ID token uc-cdis/fence#600 )---a required claim by psa (and oidc specifications)---that results in AuthTokenError exception:

    # Validate the nonce to ensure the request was not modified
    nonce = id_token.get('nonce')
    if not nonce:
    raise AuthTokenError(self, 'Incorrect id_token: nonce')
    nonce_obj = self.get_nonce(nonce)
    if nonce_obj:
    self.remove_nonce(nonce_obj.id)
    else:
    raise AuthTokenError(self, 'Incorrect id_token: nonce')

    Hence, either psa should make nonce optional (Allow nonce to be optional in OIDC Authorization workflow #315) or Fence implement it. IMHO, based on OIDC-specs (see the following quote), the latter is preferred.

    If present in the Authentication Request, Authorization Servers MUST include a nonce Claim in the ID Token with the Claim Value being the nonce value sent in the Authentication Request.
    (Ref)

@stale
Copy link

stale bot commented Mar 22, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale issues (closing soon) label Mar 22, 2020
@stale stale bot closed this Mar 29, 2020
@omab omab reopened this Jan 9, 2021
@stale stale bot removed the stale Stale issues (closing soon) label Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants