Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Azure AD B2C base url to the latest url as stated in the Microsoft docs #459

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jonatns
Copy link

@jonatns jonatns commented May 7, 2020

Proposed changes

Using login.microsoftonline.com for Azure AD B2C has been deprecated and it will be removed later this year. See Deprecation notice. Even though login.microsoftonline.com is still being supported by Microsoft I was not able to get it working for a new Azure AD B2C Tenant. Updating the BASE_URL to the new url and moving the policy to the url itself instead of a query parameter works correctly. This is how it's stated in the latest docs for Azure AD B2C OpenID Connect.

Types of changes

Please check the type of change your PR introduces:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (PEP8, lint, formatting, renaming, etc)
  • Refactoring (no functional changes, no api changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build related changes (build process, tests runner, etc)
  • Other (please describe):

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Other information

SOCIAL_AUTH_AZUREAD_B2C_OAUTH2_TENANT_ID was changed to SOCIAL_AUTH_AZUREAD_B2C_OAUTH2_TENANT_NAME since only the tenant name is needed now.

@jonatns jonatns changed the title Update Azure AD B2C base url to latest as stated in the Microsoft docs Update Azure AD B2C base url to latest url as stated in the Microsoft docs May 7, 2020
@jonatns jonatns changed the title Update Azure AD B2C base url to latest url as stated in the Microsoft docs Update Azure AD B2C base url to the latest url as stated in the Microsoft docs May 7, 2020
@jonatns jonatns closed this May 7, 2020
@digismack
Copy link
Contributor

I recently ran into this situation and had to create a new backend locally for this. I'm unclear on if (or how) the current Azure B2C backend would still be functional for anyone based on the changes Microsoft has made recently to this flow.

The only thing I can think of is that they may still be maintaining backwards compatibility for B2C tenants that were created prior to some date in the past.

I'd love to hear feedback from anyone using the Azure B2C backend. Thanks!

@digismack digismack reopened this Nov 30, 2021
@nijel
Copy link
Member

nijel commented Dec 14, 2021

Looks good. Can you please also add documentation for this to https://github.com/python-social-auth/social-docs/blob/master/docs/backends/azuread.rst?

@svdHero
Copy link

svdHero commented Aug 1, 2022

@nijel How can I test this? Can I get this PR as a docker image somehow so that I can easily run it in my cloud environment? Also, the status above indicates some conflicts.

I am happy to help if you guys assist and guide me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants