bpo-41004: IPv4Interface, and IPv6Interface hash collisions

[sreev]

Automerge-Triggered-By: @ericvsmith

https://bugs.python.org/issue41004

[the-knights-who-say-ni]

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@sreev

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

[sreev]

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@sreev

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Just signed the CLA. Thanks.
/Sree

[amiremohamadi]

Hi @sreev!
I think this change will need a NEWS entry.
you can add NEWS using https://blurb-it.herokuapp.com/

[ericvsmith]

It would be good to add some tests for this. Maybe just something that asserts that two IPv4Interface objects have different hashes. Same for IPv6Interface.

And as noted elsewhere, it needs a NEWS entry.

[bedevere-bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[ned-deily]

It looks like this PR has been superseded by #21033?

[kirotawa]

Hi,

Is this issue completely solved already? I'm seeing "resolved" in https://bugs.python.org/issue41004 , but here it's still open. So just would like to be sure.

[iritkatriel]

This was indeed fixed already in #21033

[sreev]

@ned-deily no worries, as long as it's fixed. thanks.
thanks, @iritkatriel .