Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-43322: Use consistent '#include' syntax in extn. tutorial #24851

Conversation

matthewhughes934
Copy link
Contributor

@matthewhughes934 matthewhughes934 commented Mar 13, 2021

Use the same format for Python header files

https://bugs.python.org/issue43322

Use the same format for Python header files
@Blackpower1972
Copy link

vstinner:urllib_basic_auth_regexLib/urllib/request.pyvstinner:urllib_basic_auth_regexexport http_proxy=http://alice.example.com:8080JunyiXie:fix/pymalloc_subinterpretervstinner:urllib_basic_auth_regexexport http_proxy=http://alice.example.com:8080

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Apr 14, 2021
@iritkatriel
Copy link
Member

There is a difference in C between these two formats. Are you suggesting this just for consistency or because you think the example is currently incorrect?

@matthewhughes934
Copy link
Contributor Author

matthewhughes934 commented May 21, 2021

There is a difference in C between these two formats. Are you suggesting this just for consistency or because you think the example is currently incorrect?

Purely for consistency. From what I understand the quotes will perform an implementation defined search then fallback to the (implementation defined) search method used by <> and I think in this case the distinction shouldn't be significant.

I think in general this looks something like "" searches around the source file with the #include directive and <> checks across some system paths, in this context I think the <> is more appropriate here, since I assume we're wanting users to build against the system CPython library, rather then e.g. cloning the repository and building there. But that's all implementation defined and I'm not sure how many compilers actually behave like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review stale Stale PR or inactive for long period of time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants