Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add originating comment to TryMergeExplainer #125959

Open
wants to merge 5 commits into
base: gh/seemethere/1/base
Choose a base branch
from

Conversation

seemethere
Copy link
Member

@seemethere seemethere commented May 10, 2024

Stack from ghstack (oldest at bottom):

Signed-off-by: Eli Uriegas eliuriegas@meta.com

Also changes the Advanced Debugging message to be buttons utilizing the
following format:

<br>

<kbd> <br> [Title][Link] <br> </kbd>

<br>

See https://github.com/MarkedDown/Buttons/blob/main/Types/KBD.md for
more information

Signed-off-by: Eli Uriegas <eliuriegas@meta.com>

[ghstack-poisoned]
@seemethere seemethere requested a review from a team as a code owner May 10, 2024 20:35
Copy link

pytorch-bot bot commented May 10, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125959

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 72d90f8 with merge base 538877d (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

seemethere added a commit that referenced this pull request May 10, 2024
Also changes the Advanced Debugging message to be buttons utilizing the
following format:

<br>

<kbd> <br> [Title][Link] <br> </kbd>

<br>

See https://github.com/MarkedDown/Buttons/blob/main/Types/KBD.md for
more information

Signed-off-by: Eli Uriegas <eliuriegasmeta.com>

ghstack-source-id: 95416b6de431234ecb97bb3b3d466d41a5b52059
Pull Request resolved: #125959
Co-authored-by: clee2000 <44682903+clee2000@users.noreply.github.com>
@seemethere seemethere marked this pull request as draft May 10, 2024 21:03
@seemethere
Copy link
Member Author

Converting to draft, appears as though the buttons don't work as I had intended, doing some investigation


Signed-off-by: Eli Uriegas <eliuriegasmeta.com>

[ghstack-poisoned]
seemethere added a commit that referenced this pull request May 10, 2024
Also changes the Advanced Debugging message to be buttons utilizing the
following format:

<br>

<kbd> <br> [Title][Link] <br> </kbd>

<br>

See https://github.com/MarkedDown/Buttons/blob/main/Types/KBD.md for
more information

Signed-off-by: Eli Uriegas <eliuriegasmeta.com>

ghstack-source-id: 2d6f769ff7fb4a22a983525dbeff29a8d167537d
Pull Request resolved: #125959

Signed-off-by: Eli Uriegas <eliuriegas@meta.com>

Signed-off-by: Eli Uriegas <eliuriegasmeta.com>

[ghstack-poisoned]
seemethere added a commit that referenced this pull request May 10, 2024
Also changes the Advanced Debugging message to be buttons utilizing the
following format:

<br>

<kbd> <br> [Title][Link] <br> </kbd>

<br>

See https://github.com/MarkedDown/Buttons/blob/main/Types/KBD.md for
more information

Signed-off-by: Eli Uriegas <eliuriegasmeta.com>

ghstack-source-id: 3c97103f13ed1299dc4578f722a31eee59907f1a
Pull Request resolved: #125959

Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
@seemethere seemethere marked this pull request as ready for review May 10, 2024 21:22
@seemethere
Copy link
Member Author

I just removed the buttons and converted it to a bulleted list


Signed-off-by: Eli Uriegas <eliuriegasmeta.com>

[ghstack-poisoned]
seemethere added a commit that referenced this pull request May 14, 2024
Also changes the Advanced Debugging message to be buttons utilizing the
following format:

<br>

<kbd> <br> [Title][Link] <br> </kbd>

<br>

See https://github.com/MarkedDown/Buttons/blob/main/Types/KBD.md for
more information

Signed-off-by: Eli Uriegas <eliuriegasmeta.com>

ghstack-source-id: 25990731ababbb030849a562e7a010848149c3d1
Pull Request resolved: #125959

Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants