Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fbcode] remove xcode_public_headers_symlinks #125966

Closed
wants to merge 1 commit into from
Closed

[fbcode] remove xcode_public_headers_symlinks #125966

wants to merge 1 commit into from

Conversation

rmaz
Copy link
Contributor

@rmaz rmaz commented May 10, 2024

Summary: These attributes do nothing in Buck 2, we can remove them.

Test Plan:

$ buck2 uquery //... > /dev/null

Differential Revision: D57169445

@rmaz @facebook-github-bot
[fbcode] remove xcode_public_headers_symlinks
1254a9a 
Summary: These attributes do nothing in Buck 2, we can remove them.

Test Plan:
```
$ buck2 uquery //... > /dev/null
```

Differential Revision: D57169445
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 10, 2024 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125966

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1254a9a with merge base ee804d2 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57169445

@rmaz rmaz requested a review from malfet May 10, 2024 21:50
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 10, 2024
facebook-github-bot pushed a commit to facebook/folly that referenced this pull request May 13, 2024
@rmaz @facebook-github-bot
remove xcode_public_headers_symlinks
c26111e 
Summary:
X-link: pytorch/pytorch#125966

These attributes do nothing in Buck 2, we can remove them.

Reviewed By: malfet

Differential Revision: D57169445

fbshipit-source-id: 6ec5d61a175fae32979a67660b07e0e33f11abb9
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

tinglvv pushed a commit to tinglvv/pytorch that referenced this pull request May 14, 2024
@rmaz @tinglvv
[fbcode] remove xcode_public_headers_symlinks (pytorch#125966)
7c7bdd1 
Summary: These attributes do nothing in Buck 2, we can remove them.

Test Plan:
```
$ buck2 uquery //... > /dev/null
```

Differential Revision: D57169445

Pull Request resolved: pytorch#125966
Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rmaz @facebook-github-bot @pytorchmergebot @malfet