Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pipelining] Add pipeline schedules #125975

Closed
wants to merge 4 commits into from

Conversation

kwen2501
Copy link
Contributor

@kwen2501 kwen2501 commented May 10, 2024

Copy link

pytorch-bot bot commented May 10, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125975

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 71d4ab7 with merge base 946b96f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ci-td-distributed oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (pipeline) release notes category labels May 10, 2024
kwen2501 added a commit that referenced this pull request May 10, 2024
ghstack-source-id: b4ef84f62566ea7490757a108ea14de27479db1f
Pull Request resolved: #125975
@kwen2501 kwen2501 requested review from H-Huang and wconstab May 10, 2024 23:01
Copy link
Contributor

@wconstab wconstab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, again assuming just code motion i am not reviewing carefully

nit: the ScheduleLoopedBFS was missing from PR desc but i added it

1. Add pipeline schedules:
- GPipe
- 1F1B
- Interleaved 1F1B
- LoopedBFS

2. Add basic forward and backward tests: 
test_schedule.py




cc mrshenli pritamdamania87 zhaojuanmao satgera gqchen aazzolini osalpekar jiayisuse H-Huang awgu penguinwu fegin XilunWu wanchaol fduwjj wz337 tianyu-l wconstab yf225 chauhang d4l3k

[ghstack-poisoned]
kwen2501 added a commit that referenced this pull request May 11, 2024
ghstack-source-id: 8d10a036fbc4dc06967986b56f4f5f5adf449cb9
Pull Request resolved: #125975
@kwen2501
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 11, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-13-py3-arm64 / test (default, 1, 3, macos-m1-stable)

Details for Dev Infra team Raised by workflow job

1. Add pipeline schedules:
- GPipe
- 1F1B
- Interleaved 1F1B
- LoopedBFS

2. Add basic forward and backward tests: 
test_schedule.py




cc mrshenli pritamdamania87 zhaojuanmao satgera gqchen aazzolini osalpekar jiayisuse H-Huang awgu penguinwu fegin XilunWu wanchaol fduwjj wz337 tianyu-l wconstab yf225 chauhang d4l3k

[ghstack-poisoned]
kwen2501 added a commit that referenced this pull request May 11, 2024
ghstack-source-id: af0cb2a2f81540039c2235d50685fa58847049c8
Pull Request resolved: #125975
1. Add pipeline schedules:
- GPipe
- 1F1B
- Interleaved 1F1B
- LoopedBFS

2. Add basic forward and backward tests: 
test_schedule.py




cc mrshenli pritamdamania87 zhaojuanmao satgera gqchen aazzolini osalpekar jiayisuse H-Huang awgu penguinwu fegin XilunWu wanchaol fduwjj wz337 tianyu-l wconstab yf225 chauhang d4l3k

[ghstack-poisoned]
kwen2501 added a commit that referenced this pull request May 11, 2024
ghstack-source-id: efe387653eadc92a503ef10ad1674918580c9c1e
Pull Request resolved: #125975
@kwen2501
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

tinglvv pushed a commit to tinglvv/pytorch that referenced this pull request May 14, 2024
1. Add pipeline schedules:
- GPipe
- 1F1B
- Interleaved 1F1B
- LoopedBFS

2. Add basic forward and backward tests:
test_schedule.py

Pull Request resolved: pytorch#125975
Approved by: https://github.com/wconstab
ghstack dependencies: pytorch#125729
pytorchmergebot pushed a commit that referenced this pull request May 14, 2024
Resolves pytorch/PiPPy#1062.

Also added a gradient equivalence test.

Pull Request resolved: #126114
Approved by: https://github.com/H-Huang
ghstack dependencies: #125729, #125975
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-td-distributed ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (pipeline) release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants