[Inductor] decompose expm1 for CPP vec #92289
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92289
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2f10c4b: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Valentine233
requested review from
jgong5 and
EikanWang
and removed request for
jgong5
jgong5
approved these changes
Jan 19, 2023
Valentine233
force-pushed
the
vec_expm1
branch
from
9ee0d2b
to
0ae3069
Compare
jansel
approved these changes
Jan 19, 2023
Valentine233
force-pushed
the
vec_expm1
branch
from
0ae3069
to
2f10c4b
Compare
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For micro-bench op
aten.elu.defaultin TIMM, the performance is not good even though with vectorization.Eluusesexpm1as a sub-op. It turns out that inductor invokes sleefexpm1function while aten decomposes it withexp - 1. The former one performs worse than the latter one. This PR decomposesexpm1for cpp vectorization to make performance come back.Performance data for eager v.s. inductor:
cc @mlazos @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @chunyuan-w @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @desertfire