Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the unmaintained dependency appdirs with platformdirs #2769

Merged
merged 4 commits into from
Jun 4, 2024

Conversation

avalentino
Copy link
Contributor

  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.91%. Comparing base (c698e31) to head (832fafb).
Report is 45 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2769      +/-   ##
==========================================
- Coverage   95.93%   95.91%   -0.03%     
==========================================
  Files         366      366              
  Lines       53528    53509      -19     
==========================================
- Hits        51351    51321      -30     
- Misses       2177     2188      +11     
Flag Coverage Δ
behaviourtests 4.04% <66.66%> (-0.01%) ⬇️
unittests 96.00% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Mar 29, 2024

Pull Request Test Coverage Report for Build 9368819369

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on feature/platformdirs at 96.031%

Totals Coverage Status
Change from base Build 9368656053: 96.0%
Covered Lines: 51561
Relevant Lines: 53692

💛 - Coveralls

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for bringing this up!

@mraspaud mraspaud added this to the v0.49.0 milestone Jun 4, 2024
@mraspaud mraspaud merged commit b71f9c6 into pytroll:main Jun 4, 2024
16 of 19 checks passed
@avalentino avalentino deleted the feature/platformdirs branch June 4, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants