Skip to content

Commit

Permalink
Fix empty methods without an abstract decorator (#6021)
Browse files Browse the repository at this point in the history
* Fix loop control variable that override iterable

* Fix empty methods without an abstract decorator

* Update pyproject.toml

* Update test_dataset.py

* Update pyvista/core/utilities/reader.py
  • Loading branch information
tkoyama010 committed May 3, 2024
1 parent 17cf1ac commit 36fd663
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,7 @@ extend-select = [
"B008",
"B009",
"B010",
"B027",
"B020",
"C4",
"COM",
Expand Down
4 changes: 4 additions & 0 deletions pyvista/core/utilities/reader.py
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,7 @@ def SetFileName(self, filename):
"""Set file name."""
self._filename = filename

@abstractmethod
def UpdateInformation(self):
"""Update Information from file."""

Expand Down Expand Up @@ -2401,6 +2402,9 @@ def __init__(self):
self._n_frames = 0
self._current_frame = 0

def UpdateInformation(self):
"""Update Information from file."""

def GetProgress(self):
return self._current_frame / self._n_frames

Expand Down

0 comments on commit 36fd663

Please sign in to comment.