This repository has been archived by the owner on Jun 14, 2020. It is now read-only.
Fix positioning edge case (fixes #837) #838
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgreter
force-pushed
the
bugfix/issue-837
branch
from
90c1091
to
d65a469
Compare
If the BODY has position: relative and overflow-x: hidden, the offset is calculated incorrectly. It takes the BODY scroll offset twice into the calculation. Also splits the BODY overflow check/calculation into X/Y components.
mgreter
force-pushed
the
bugfix/issue-837
branch
from
d65a469
to
6604e20
Compare
|
hey, buddy. Its looks like we need to calculate x/y when container is not only body and its scrollable. Could you take a look at this issue? Maybe its related to your fix |
m1lk1way
reviewed
Mar 21, 2018
| @@ -238,15 +244,22 @@ PROTOTYPE.reposition.offset = function(elem, pos, container) { | |||
| pos.left -= parentOffset.left + (parseFloat($.css(parent, 'marginLeft')) || 0); | |||
| pos.top -= parentOffset.top + (parseFloat($.css(parent, 'marginTop')) || 0); | |||
|
|
|||
| if (parent.tagName.toLowerCase() === 'BODY') { break; } | |||
There was a problem hiding this comment.
this won't ever happen, cause "BODY".toLowerCase() won't be BODY
There was a problem hiding this comment.
I guess I did not put it there for no reason, but your correct, it will of course not work.
I can only guess that I messed that one up when reviewing my PR before submitting.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the BODY has position: relative and overflow-x: hidden,
the offset is calculated incorrectly. It takes the BODY
scroll offset twice into the calculation. Also splits the
BODY overflow check/calculation into X/Y components.
Fixes #837
Not sure how correct this fix is, maybe the split into X/Y
scroll components isn't needed either. Not completely sure
I understand what the patched function is supposed to do.