Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: add option to export all lines with minimal width in dxf export #57254

Merged
merged 6 commits into from May 1, 2024

Conversation

mhugent
Copy link
Contributor

@mhugent mhugent commented Apr 26, 2024

This PR adds an option to the dxf export to write all lines with minimal width 0 (hairline) if enabled. DXF-Lines having zero width stay minimal in the CAD regardless of the zoom-level, so this is quite usefull for doing further CAD-editing with the exported dxf, especially if there are many features next to each other on the map.

Going to add a unit test and support for access via server and processing to the PR.

The option can be enabled/disabled in the dxf dialog:

dxf_export_minimum_line_width

Funded by Stadtwerke München

@github-actions github-actions bot added this to the 3.38.0 milestone Apr 26, 2024
@nyalldawson
Copy link
Collaborator

Is there a clearer checkbox label we can use here? Should we just go with an explicit "export lines with zero width"?

@mhugent
Copy link
Contributor Author

mhugent commented Apr 29, 2024

Is there a clearer checkbox label we can use here? Should we just go with an explicit "export lines with zero width"?

'export lines with zero width' sounds good

@nyalldawson nyalldawson merged commit 33b2e4b into qgis:master May 1, 2024
29 of 30 checks passed
@nyalldawson nyalldawson added Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels May 1, 2024
@qgis-bot
Copy link
Collaborator

qgis-bot commented May 1, 2024

@mhugent

This pull request has been tagged for the changelog.

  • The description will be harvested so please provide a "nearly-ready" text for the final changelog
  • If possible, add a nice illustration of the feature. Only the first one in the description will be harvested (GIF accepted as well)
  • If you can, it's better to give credits to your sponsor, see below for different formats.

You can edit the description.

Format available for credits
  • Funded by NAME
  • Funded by URL
  • Funded by NAME URL
  • Sponsored by NAME
  • Sponsored by URL
  • Sponsored by NAME URL

Thank you!

@qgis-bot
Copy link
Collaborator

qgis-bot commented May 1, 2024

@mhugent
A documentation ticket has been opened at qgis/QGIS-Documentation#9070
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

@qgis-bot
Copy link
Collaborator

qgis-bot commented May 1, 2024

@mhugent
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog Items that are queued to appear in the visual changelog - remove after harvesting Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants