Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Server GetPrint set HTML content of QgsLayoutItemHtml and not only URL #56777

Merged

Conversation

rldhont
Copy link
Contributor

@rldhont rldhont commented Mar 8, 2024

Since QGIS 3.32, when QGIS and QGIS Server loading Project with old HTML-enabled label items, it was automatically into html items. #53192

QGIS Server GetPrint request provides the ability to update label and html items, but for html items, it only accept URL.

QGIS Server was not taken into account the html item content mode, so the automotically migrate old HTML-enabled label items into html items can no longer be modifiable. They were only clear if the value provided is not an URL.

Funded by 3Liz

…t only URL

Since QGIS 3.32, when QGIS and QGIS Server loading Project with old HTML-enabled label items, it was automatically into html items. qgis#53192

QGIS Server GetPrint request provides the ability to update label and html items, but for html items, it only accept URL.

QGIS Server was not taken into account the html item content mode, so the automotically migrate old HTML-enabled label items into html items can no longer be modifiable. They were only clear if the value provided is not an URL.

Funded by 3Liz
@rldhont rldhont added Server Related to QGIS server Print Layouts Related to QGIS Print Layouts, Atlas or Reporting frameworks backport release-3_34 backport release-3_36 labels Mar 8, 2024
@github-actions github-actions bot added this to the 3.38.0 milestone Mar 8, 2024
Copy link

github-actions bot commented Mar 8, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit d9379d7)

@rldhont
Copy link
Contributor Author

rldhont commented Mar 10, 2024

Unrelated failed test : ProcessingGrassAlgorithmsRasterTestPt2

@rldhont rldhont closed this Mar 12, 2024
@rldhont rldhont reopened this Mar 12, 2024
@rldhont rldhont requested a review from mhugent March 12, 2024 13:47
@rldhont
Copy link
Contributor Author

rldhont commented Mar 13, 2024

All tests are green.

@elpaso, @pblottiere , @mhugent what do you think about this fix ?

@rldhont
Copy link
Contributor Author

rldhont commented Mar 22, 2024

could it be reviewed before 3.34.5 released ?

@pblottiere
Copy link
Member

it looks good to me 👍

Copy link
Contributor

@troopa81 troopa81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Do you mind adding a test?

Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-3_34 backport release-3_36 Print Layouts Related to QGIS Print Layouts, Atlas or Reporting frameworks Server Related to QGIS server stale Uh oh! Seems this work is abandoned, and the PR is about to close.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants