New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Server GetPrint set HTML content of QgsLayoutItemHtml and not only URL #56777
[Bugfix] Server GetPrint set HTML content of QgsLayoutItemHtml and not only URL #56777
Conversation
…t only URL Since QGIS 3.32, when QGIS and QGIS Server loading Project with old HTML-enabled label items, it was automatically into html items. qgis#53192 QGIS Server GetPrint request provides the ability to update label and html items, but for html items, it only accept URL. QGIS Server was not taken into account the html item content mode, so the automotically migrate old HTML-enabled label items into html items can no longer be modifiable. They were only clear if the value provided is not an URL. Funded by 3Liz
Unrelated failed test : |
All tests are green. @elpaso, @pblottiere , @mhugent what do you think about this fix ? |
could it be reviewed before 3.34.5 released ? |
it looks good to me 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. Do you mind adding a test?
The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check
|
Since QGIS 3.32, when QGIS and QGIS Server loading Project with old HTML-enabled label items, it was automatically into html items. #53192
QGIS Server GetPrint request provides the ability to update label and html items, but for html items, it only accept URL.
QGIS Server was not taken into account the html item content mode, so the automotically migrate old HTML-enabled label items into html items can no longer be modifiable. They were only clear if the value provided is not an URL.
Funded by 3Liz