Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Symbol Expression as variable in Layout Legend #56920

Closed
wants to merge 2 commits into from

Conversation

roya0045
Copy link
Contributor

Description

Updated implementation.

This PR allows the user to access the expression representing a symbol rule in the Legend of a layout.

This allows the end user to perform calculation taking into acocunt the symbology.

PR aims to fix #21988 & fix #33312

@github-actions github-actions bot added this to the 3.38.0 milestone Mar 20, 2024
Copy link

github-actions bot commented Mar 20, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 21e325b)

Copy link

Tests failed for Qt 6

One or more tests failed using the build from commit 36cafc3

composer_legend_symbol_expression

composer_legend_symbol_expression

Test failed at testSymbolExpressionRender at tests/src/python/test_qgslayoutlegend.py:775

Rendered image did not match tests/testdata/control_images/composer_legend/expected_composer_legend_symbol_expression/expected_composer_legend_symbol_expression.png (found 437 pixels different)

The full test report (included comparison of rendered vs expected images) can be found here.

Further documentation on the QGIS test infrastructure can be found in the Developer's Guide.

Copy link

Tests failed for Qt 5

One or more tests failed using the build from commit 36cafc3

composer_legend_symbol_expression

composer_legend_symbol_expression

Test failed at testSymbolExpressionRender at tests/src/python/test_qgslayoutlegend.py:775

Rendered image did not match tests/testdata/control_images/composer_legend/expected_composer_legend_symbol_expression/expected_composer_legend_symbol_expression.png (found 278 pixels different)

The full test report (included comparison of rendered vs expected images) can be found here.

Further documentation on the QGIS test infrastructure can be found in the Developer's Guide.

Copy link

github-actions bot commented Apr 6, 2024

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Apr 6, 2024
Copy link

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

@github-actions github-actions bot closed this Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Uh oh! Seems this work is abandoned, and the PR is about to close.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use aggregate fucntions in Text on Symbol expressions Expression for Map Composer Legend
1 participant