Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Attribute Table header labels when adding multiple columns #56969

Merged
merged 1 commit into from Apr 15, 2024

Conversation

CodeBardian
Copy link
Contributor

@CodeBardian CodeBardian commented Mar 25, 2024

Retrieving the column labels in the attribute table from the source model addresses some cases where the attribute table would not show a column name when adding more fields.

This was intended to fix #55533. I just noticed it seems to unintentionally also fix #49142.

Fixes #55533
Fixes #49142

@github-actions github-actions bot added this to the 3.38.0 milestone Mar 25, 2024
Copy link

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 068e83e)

Copy link

github-actions bot commented Apr 9, 2024

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Apr 9, 2024
@agiudiceandrea agiudiceandrea added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Apr 10, 2024
@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Apr 11, 2024
@nyalldawson nyalldawson merged commit 0f9b830 into qgis:master Apr 15, 2024
40 checks passed
@nyalldawson
Copy link
Collaborator

Thanks @CodeBardian !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport queued_ltr_backports Queued Backports backport release-3_36 Bug Either a bug report, or a bug fix. Let's hope for the latter!
Projects
None yet
3 participants