Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to support msvc builds with qt6 #56980

Closed
wants to merge 1 commit into from
Closed

Conversation

jef-n
Copy link
Member

@jef-n jef-n commented Mar 27, 2024

No description provided.

@github-actions github-actions bot added this to the 3.38.0 milestone Mar 27, 2024
Copy link

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit ce3f743)

@MehdiChinoune
Copy link
Contributor

I tried before to fix building against Qt6 on Windows by using ANSI *A functions in #52175 but It was rejected, I was ordered to use UNICODE *W functions.
@m-kuhn

@m-kuhn
Copy link
Member

m-kuhn commented Mar 27, 2024

I was hoping we could switch to unicode, see #56841

Comment on lines +517 to +519
if(MSVC AND BUILD_WITH_QT6)
qt_disable_unicode_defines(${QGIS_APP_NAME})
endif(MSVC AND BUILD_WITH_QT6)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably not be added, #56980 should fix this

@m-kuhn
Copy link
Member

m-kuhn commented Mar 29, 2024

Looks good, but I think we should start using the Widechar version now that we are touching this code and Qt made this the standard with Qt6

Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Apr 14, 2024
Copy link

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

@github-actions github-actions bot closed this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Uh oh! Seems this work is abandoned, and the PR is about to close.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants