[api] Add QgsProject::crs3D #57107
Merged
[api] Add QgsProject::crs3D #57107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rouault @wonder-sk as previously discussed |
uclaros
reviewed
Apr 10, 2024
|
@nyalldawson is this going to work if 3D Geographic (e.g. EPSG:4979) or Geocentric (e.g. EPSG:4978) CRS is set as the project CRS? Or is support for that out of scope for now? |
It works fine for this situation:
|
|
@wonder-sk I've applied some more related refinements here |
rouault
reviewed
Apr 23, 2024
src/core/project/qgsproject.cpp
Outdated
| case Qgis::CrsType::Unknown: | ||
| case Qgis::CrsType::Geodetic: | ||
| case Qgis::CrsType::Geographic2d: | ||
| case Qgis::CrsType::Projected: |
There was a problem hiding this comment.
some Projected CRS might already be 3D. You should probably check the axis count
There was a problem hiding this comment.
Thanks @rouault !
rouault
approved these changes
Apr 23, 2024
Returns the CRS to use for the project when transforming 3D data, or when z/elevation value handling is important. The returned CRS will take into account verticalCrs(), e.g. by returning a compound CRS consisting of crs() + verticalCrs(). This method may still return a 2D CRS, e.g in the case that crs() is a 2D CRS and no verticalCrs() has been set for the project. I.E. It is NOT guaranteed that the returned CRS will actually be a 3D CRS, but rather it is guaranteed that the returned CRS is **ALWAYS** the most appropriate CRS to use when handling 3D data.
Report proj error when compound crs cannot be created
or geocentric Following https://docs.ogc.org/as/18-005r5/18-005r5.html#34 it is not a valid combination to create a compound crs from these types
Can be used to test if a crs contains a vertical axis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returns the CRS to use for the project when transforming 3D data, or when z/elevation value handling is important.
The returned CRS will take into account verticalCrs(), e.g. by returning a compound CRS consisting of crs() + verticalCrs().
This method may still return a 2D CRS, e.g in the case that crs() is a 2D CRS and no verticalCrs() has been set for the project. I.E. It is NOT guaranteed that the returned CRS will actually be a 3D CRS, but rather it is guaranteed that the returned CRS is ALWAYS the most appropriate CRS to use when handling 3D data.
Refs discussion in #56791, qgis/QGIS-Enhancement-Proposals#267