Fix light model updates #57257
Merged
Fix light model updates #57257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure there is something to remove or add before making calls to begin/end update methods. Can otherwise lead to unnecessary updates and potential crashes. Signed-off-by: Mike Krus <mike.krus@kdab.com>
mkrus
force-pushed
the
fix_light_model_reset
branch
from
86f5104
to
84cd4a4
Compare
nyalldawson
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure there is something to remove or add before making calls to begin/end update methods. Can otherwise lead to unnecessary updates and potential crashes.