Add preload-font for CLJS version and fix available-fonts function

[Norgat]

Start point: https://groups.google.com/forum/#!topic/clj-processing/9S47cbGQ3bY

Reason for adding new function: Processing.js load font through css font-family and parse @pjs tag in comments.

Example of usage: https://github.com/Norgat/quil/blob/master/test/cljs/snippets/manual.cljs#L157

Processing.js docs:
http://processingjs.org/reference/pjs%20directive/
http://processingjs.org/reference/font/

Externs for Processing.js updated: quil/processing-js@f6c8321

P.S. call @cassiel

[nbeloglazov]

Why are you updating processing-js version?

[Norgat]

Previous version of quil/processing-js is 1.6.4.0.

I add new section for PFont and change version number to 1.6.4.1 (because we have a new saved words in externs). Commit: quil/processing-js@f6c8321

I don't know we 1.6.3.0 version used in current Quil project file.

[nbeloglazov]

You should pull master branch. Currently 1.6.4.0 is used: https://github.com/quil/quil/blob/master/project.clj#L19

Also I need to push 1.6.4.1 to clojars then.

[nbeloglazov]

Can we do font preloading inside create-font so that user won't need to do it by themselves?

[Norgat]

This increase the gap between Processing.js docs and Quil.
Do you think that is good idea? Because we hide font loading process from user in this case.

So, what happened if user call create-font inside :draw handler with slow fonts cdn?
I think he will see strange artifacts.

P.S. Yes, fonts are cached inside Processing.js and we don't need to reload it.

[nbeloglazov]

There is no preload-font in processing.js anyway, so it's not increasing gap. Quil is not a low level library so it's better if we hide these implementation details from users. If you user calls create-font from inside :draw then only the first call to preloading will have effect and all others will be cached so there won't be performance issues.

But what happens if user tries to preload built-in font? Is it possible to know if user is using built-in font or font from a file?

[nbeloglazov]

This should have the same indentation as aget:

(.add 
  (aget ...
  font-url))

Otherwise it looks like font-url is argument for aget

[nbeloglazov]

You should pull master branch. Currently 1.6.4.0 is used: https://github.com/quil/quil/blob/master/project.clj#L19

Also I need to push 1.6.4.1 to clojars then.

[nbeloglazov]

There is no preload-font in processing.js anyway, so it's not increasing gap. Quil is not a low level library so it's better if we hide these implementation details from users. If you user calls create-font from inside :draw then only the first call to preloading will have effect and all others will be cached so there won't be performance issues.

But what happens if user tries to preload built-in font? Is it possible to know if user is using built-in font or font from a file?

[nbeloglazov]

Maksim you're not waiting on me, right? We still need to resolve the issue "new preload-font" or "update create-font".

[Norgat]

@nbeloglazov I await your decision. Do you accept or not its current changes?
I expressed my opinion in my code. I prefer preload-font way.

If you have different opinion - write it. I described all available data and possible ways to resolve this problem.

[nbeloglazov]

Having single create-font is less confusing than both create-font and preload-font. It's not clear how "creating" is different from "preloading". It's better to hide low-level implementation details from users, especially given that quil is fairly high-level library.

I can't think of any performance issues if create-font is called inside :draw: only the first call loads the font while all the rest do nothing. If user still wants to optimize it - they can move create-font call to :setup.

[Norgat]

Ok, I realize this approach the weekend. 2017-03-02 10:12 GMT+04:00 Nikita Beloglazov <notifications@github.com>:

…

Having single create-font is less confusing than both create-font and preload-font. It's not clear how "creating" is different from "preloading". It's better to hide low-level implementation details from users, especially given that quil is fairly high-level library. I can't think of any performance issues if create-font is called inside :draw: only the first call loads the font while all the rest do nothing. If user still wants to optimize it - they can move create-font call to :setup. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#203 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABbMN52v7ZCIWxufZud8AxG0X6TZjtLWks5rhl3WgaJpZM4MHavg> .

-- Karandashov M.V. (Norgat)

[marco-m]

Hello, any news ?