Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix override slug if slug is set to empty #182

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ronilaukkarinen
Copy link

Fixes the bug where this option doesn't work if set to empty:

SCR-20240517-lqwm-2

SCR-20240517-lrai-2

Tested the PR and it's working when using null check instead of ! empty.

Copy link

sweep-ai bot commented May 17, 2024

Sweep: PR Review

includes/class-core.php

The primary change allows for empty strings as valid slugs by modifying the condition to check for null instead of not empty, along with minor formatting improvements.

Potential Issues

  • Changing the condition to check for null instead of not empty allows empty strings as valid slugs, which could lead to unexpected behavior if empty slugs are not handled properly.
  • if ( null !== Settings::get( 'quillforms_slug' ) ) {

    View Diff


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant