Skip to content

Commit

Permalink
German translation updates from br Abdul-Raqeeb
Browse files Browse the repository at this point in the history
  • Loading branch information
@ahmedre
ahmedre committed Feb 3, 2017
1 parent b3ed33c commit 124a771
Show file tree
Hide file tree
Showing 3 changed files with 433 additions and 256 deletions.
4 changes: 4 additions & 0 deletions app/src/main/res/values-de/booleans.xml
View file
@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
<bool name="show_sura_names_translation">true</bool>
</resources>

6 comments on commit 124a771

@ozbek
Copy link
Contributor

@ozbek ozbek commented on 124a771 Feb 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No consistency at all. Sorry, but I hate inconsistency.

@ahmedre
Copy link
Contributor Author

@ahmedre ahmedre commented on 124a771 Feb 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, i didn't review too carefully honestly -
don't be sad :) PR or i can ask the bro to fix it - either way

@ozbek
Copy link
Contributor

@ozbek ozbek commented on 124a771 Feb 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ask him if he agrees with those changes and wills to make the changes. I would not want to mess with the language I don't entirely speak :)

@Omerturger
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As-salaamu 'alaikum brothers, barakAllahu feekum for your time.
I didn't understand, do you mean just use one word instead of using semicolon?

@ozbek
Copy link
Contributor

@ozbek ozbek commented on 124a771 Feb 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wa alaikum assalam. What I personally meant is 1) do not use parenthesis, 2) use punctuation symbols consistently. Additionally, maybe you could stick to one (the most popular) variation of translation and use only that one here.

@Omerturger
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tamam Shuhrat abi, will then only use the most popular translation itself.
Paranthesis were inspired by english Hilali/Khan explanation, because without, not everybody will understand what is meant.
Maybe to clarify surah names we could add some explanation or introduction for every surah?
Like ''name, revelation, topics'' quickly found on google here for example: http://www.englishtafsir.com/
And longpress on surah name, to get those infos.

Please sign in to comment.