Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid do.call() when resetting options #74

Merged
merged 2 commits into from Jun 4, 2018
Merged

avoid do.call() when resetting options #74

merged 2 commits into from Jun 4, 2018

Conversation

mtmorgan
Copy link
Contributor

@mtmorgan mtmorgan commented Jun 1, 2018

mtmorgan and others added 2 commits June 1, 2018 15:35
@mtmorgan
avoid do.call() when resetting options
3543f28 
- evaluates arguments, so in particular error = ... fails
- fixes r-lib#73
@jimhester
Add note to NEWS
dd27ef0
@jimhester
Copy link
Member

Thanks Martin, makes sense and the patch looks good to me!

@jimhester jimhester merged commit dbcd7cd into r-lib:master Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

local_options() evaluates error handler functions, fails to restore original handler
2 participants
@mtmorgan @jimhester