[tui][edi] List continuation on new line #313
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harshil-Jani <harshiljani2002@gmail.com>
Signed-off-by: Harshil-Jani <harshiljani2002@gmail.com>
nazmulidris
force-pushed
the
main
branch
2 times, most recently
from
a69d408
to
f51f118
Compare
nazmulidris
force-pushed
the
main
branch
4 times, most recently
from
570edf3
to
978baba
Compare
[tui][edi] Auto-Closing tags for delimeters
nazmulidris
force-pushed
the
main
branch
5 times, most recently
from
025359b
to
a0e8136
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented list continuation for
One though of reflection was that I tried to understand about the AST from MdDocument data structure but it was way to much of work since we would be need to replace lines from the editor buffer with AST implementation. But an added advantage would be the inline list continual. As per the current thinking, we try parsing each line and inlines doesn't have a way by which we can tell it is a part of smart list. Having an AST would help us know if the case is part of list or not. It's a good trade off. I hope the PR would really make a clear thought on if we need AST or not.