Skip to content

Commit

Permalink
Fix multipart uploads on 1.9
Browse files Browse the repository at this point in the history
  • Loading branch information
@raggi
raggi committed Apr 28, 2009
1 parent 40eba67 commit 44ed464
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion lib/rack/utils.rb
View file
@@ -1,3 +1,5 @@
# coding=binary

require 'set'
require 'tempfile'

Expand Down Expand Up @@ -351,7 +353,7 @@ def self.parse_multipart(env)
input = env['rack.input']
input.rewind

boundary_size = boundary.size + EOL.size
boundary_size = Utils.bytesize(boundary) + EOL.size
bufsize = 16384

content_length -= boundary_size
Expand Down

9 comments on commit 44ed464

@josh
Copy link
Contributor

@josh josh commented on 44ed464 Apr 29, 2009

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omg, that was its! I totally looked over it.

Can you please cherry-pick this into 1-0-stable.

@raggi
Copy link
Member Author

@raggi raggi commented on 44ed464 Apr 29, 2009

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@minad
Copy link

@minad minad commented on 44ed464 Sep 15, 2009

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When do you release a new rack version? This patch is still not included in a stable version

@co-hack
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to a 1.0.1 release with this patch $)

@giddie
Copy link

@giddie giddie commented on 44ed464 Sep 17, 2009

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please release a 1.0.1 asap. This is a pretty important fix!

@sporkmonger
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also +1 to getting this out ASAP.

@jasonmadigan
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, this is pretty important.

@josh
Copy link
Contributor

@josh josh commented on 44ed464 Oct 5, 2009

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please spam this post: http://groups.google.com/group/rack-devel/browse_thread/thread/0e5c1973a675d026/579a614f5860011f

@geetarista
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for this one. Otherwise paperclip uploads die in Ruby 1.9.

Please sign in to comment.