Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document rewind behavior change of rack input. #2153

Merged
merged 1 commit into from Jan 31, 2024

Conversation

dblock
Copy link
Contributor

@dblock dblock commented Jan 31, 2024

Coming from #2152 I think the upgrade guide can do a better job documenting the new behavior of rack.input wrt .rewind.

UPGRADE-GUIDE.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jeremyevans jeremyevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jeremyevans jeremyevans merged commit 25e0e01 into rack:main Jan 31, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants