Backport 2104 3-0-stable #2164
Merged
Backport 2104 3-0-stable #2164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
approved these changes
Mar 20, 2024
jeremyevans
requested changes
Mar 20, 2024
lib/rack/multipart/parser.rb
Outdated
| @@ -213,6 +213,8 @@ def initialize(boundary, tempfile, bufsize, query_parser) | |||
|
|
|||
| @sbuf = StringScanner.new("".dup) | |||
| @body_regex = /(?:#{EOL}|\A)--#{Regexp.quote(boundary)}(?:#{EOL}|--)/m | |||
| @body_regex_at_end = /#{@body_regex}\z/m | |||
There was a problem hiding this comment.
I don't think @body_regex_at_end is used by this code, so it should not be added.
There was a problem hiding this comment.
Oops, it came with the cherry pick by accident. I removed it.
Return empty when parsing a multi-part POST with only one end delimiter. Fixed: rack#2103 Sending the following request in a browser generates a request with with only one end delimiter. ```javascript const formData = new FormData(); const request = new Request('http://127.0.0.1:8080/', { method: 'POST', body: formData, }); const response = fetch(request); ``` ``` curl 'http://127.0.0.1:8080/' \ -H 'Content-Type: multipart/form-data; boundary=----WebKitFormBoundaryR1LC4tR6ayskIXJm' \ --data-raw $'------WebKitFormBoundaryR1LC4tR6ayskIXJm--\r\n' ``` This request is not compliant RFC7578, but is generated by major browsers such as FireFox and Chrome. Supporting this request will cause the multipart parser to return an empty value.
JoeDupuis
force-pushed
the
backport-2104-3-0-stable
branch
from
a160e08
to
47351c9
Compare
jeremyevans
approved these changes
Mar 20, 2024
|
Thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix #2104 backported to 3-0-stable (to cut a release).
Follow up from #2163