Make sure to never use B::PADOP->gv, as it tries to look up values fr…

…om random pads. This can easily lead to segfaults. See also perl RT#74040.
rafl · Apr 5, 2010 · 248a233 · 248a233
1 parent 90a815b
commit 248a233
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/lib/Devel/Caller.pm b/lib/Devel/Caller.pm
@@ -92,14 +92,19 @@ sub called_with {
             }
 
             my $consider = ($op->name eq "gvsv") ? $op : $prev;
-            my $gv = $consider->gv;
-            print "consider: $consider ", $consider->name, " gv $gv\n"
-              if $DEBUG;
+            my $gv;
+
             if (ref $consider eq 'B::PADOP') {
                 print "GV is really a padgv\n" if $DEBUG;
                 $gv = $padv->ARRAYelt( $consider->padix );
                 print "NEW GV $gv\n" if $DEBUG;
             }
+            else {
+                $gv = $consider->gv;
+            }
+
+            print "consider: $consider ", $consider->name, " gv $gv\n"
+              if $DEBUG;
 
             if ($want_names) {
                 my %sigils = (