Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added RIP 71 MD in PROPOSALS #110

Merged
merged 2 commits into from
Oct 20, 2022
Merged

added RIP 71 MD in PROPOSALS #110

merged 2 commits into from
Oct 20, 2022

Conversation

bitbeckers
Copy link
Contributor

Added MarkDown file to wrap up RIP. MarkDown covers proposal and deliverables

@bitbeckers bitbeckers linked an issue Oct 17, 2022 that may be closed by this pull request
RIP: RG Styleguide #71
Closed
@bitbeckers bitbeckers self-assigned this Oct 17, 2022
@bitbeckers bitbeckers requested a review from plor October 17, 2022 13:07
plor
plor reviewed Oct 17, 2022
View reviewed changes
Copy link
Contributor

@plor plor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know whether the RIP number should be the issue number. So far they have all been incremental with no skips. This might be confusing, so maybe your naming is the right approach.

@bitbeckers
Copy link
Contributor Author

@plor so what should we do? I just went with what I know from EIPs so maybe my bad

@plor
Copy link
Contributor

plor commented Oct 19, 2022

I think switch to rip-30. It is tricky to break a pattern once it is established, even if it breaks a pattern it was based on.

@bitbeckers
Copy link
Contributor Author

@plor done!

@plor plor merged commit 52033eb into master Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plor plor plor approved these changes

Assignees

@bitbeckers bitbeckers

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RIP: RG Styleguide
2 participants
@bitbeckers @plor