Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Performance: add GC metrics for # of runs and total runtime
- Loading branch information
Showing
1 changed file
with
48 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1e0d2e3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m getting a const_missing for RubyProf::GC_RUNS and RubyProf::GC_TIME with vanilla ruby-prof (from your fork, Jeremy) – I’m probably missing a patch of some sort.
Anyway, the Mode assignments to these constants probably should be done conditionally.
1e0d2e3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, good point :) Fixed in fd27488
1e0d2e3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is great stuff you’re doing btw (this and the perf improvements). :)
1e0d2e3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What patch do I need for this? I’m really curious about the GC numbers :)