Skip to content

Commit

Permalink
Remove CGI::Session memory leak patch
Browse files Browse the repository at this point in the history
  • Loading branch information
josh committed Dec 17, 2008
1 parent ec1bd98 commit 246b582
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions actionpack/lib/action_controller/base.rb
Expand Up @@ -1160,13 +1160,8 @@ def expires_now #:doc:
def reset_session #:doc:
request.reset_session
@_session = request.session
#http://rails.lighthouseapp.com/projects/8994/tickets/1558-memory-problem-on-reset_session-in-around_filter#ticket-1558-1
#MRI appears to have a GC related memory leak to do with the finalizer that is defined on CGI::Session
ObjectSpace.undefine_finalizer(@_session)
response.session = @_session
end


private
def render_for_file(template_path, status = nil, layout = nil, locals = {}) #:nodoc:
logger.info("Rendering #{template_path}" + (status ? " (#{status})" : '')) if logger
Expand Down

0 comments on commit 246b582

Please sign in to comment.