Only dup local cache values if duplicable [#1653 state:resolved]

rails · Jan 29, 2009 · 2e69db1 · 2e69db1
1 parent a1a9889
commit 2e69db1
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/activesupport/lib/active_support/cache/strategy/local_cache.rb b/activesupport/lib/active_support/cache/strategy/local_cache.rb
@@ -41,7 +41,7 @@ def read(key, options = nil)
             value
           else
             # forcing the value to be immutable
-            value.dup
+            value.duplicable? ? value.dup : value
           end
         end
 

diff --git a/activesupport/test/caching_test.rb b/activesupport/test/caching_test.rb
@@ -81,6 +81,11 @@ def test_should_read_and_write_hash
     assert_equal({:a => "b"}, @cache.read('foo'))
   end
 
+  def test_should_read_and_write_integer
+    @cache.write('foo', 1)
+    assert_equal 1, @cache.read('foo')
+  end
+
   def test_should_read_and_write_nil
     @cache.write('foo', nil)
     assert_equal nil, @cache.read('foo')
@@ -200,6 +205,13 @@ def test_local_cache_of_read_and_write
       end
     end
 
+    def test_local_cache_should_read_and_write_integer
+      @cache.with_local_cache do
+        @cache.write('foo', 1)
+        assert_equal 1, @cache.read('foo')
+      end
+    end
+
     def test_local_cache_of_delete
       @cache.with_local_cache do
         @cache.write('foo', 'bar')