Skip to content

Commit

Permalink
Support OPTIONS verb in route conditions [#1727 state:resolved]
Browse files Browse the repository at this point in the history
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
  • Loading branch information
Mike Gunderloy authored and lifo committed Mar 8, 2009
1 parent 5c87e9a commit 5e0f621
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
2 changes: 1 addition & 1 deletion actionpack/lib/action_controller/routing.rb
Expand Up @@ -267,7 +267,7 @@ module ActionController
module Routing
SEPARATORS = %w( / . ? )

HTTP_METHODS = [:get, :head, :post, :put, :delete]
HTTP_METHODS = [:get, :head, :post, :put, :delete, :options]

ALLOWED_REQUIREMENTS_FOR_OPTIMISATION = [:controller, :action].to_set

Expand Down
8 changes: 8 additions & 0 deletions actionpack/test/controller/routing_test.rb
Expand Up @@ -1865,6 +1865,14 @@ def test_route_requirements_with_invalid_http_method_is_invalid
end
end

def test_route_requirements_with_options_method_condition_is_valid
assert_nothing_raised do
set.draw do |map|
map.connect 'valid/route', :controller => 'pages', :action => 'show', :conditions => {:method => :options}
end
end
end

def test_route_requirements_with_head_method_condition_is_invalid
assert_raises ArgumentError do
set.draw do |map|
Expand Down

0 comments on commit 5e0f621

Please sign in to comment.