@@ -129,7 +129,7 @@ module ActionView # label_tag 'name', nil, :class => 'small_label' # # => <label for="name" class="small_label">Name</label> def label_tag(name, text = nil, options = {}) - content_tag :label, text || name.humanize, { "for" => name }.update(options.stringify_keys) + content_tag :label, text || name.to_s.humanize, { "for" => name }.update(options.stringify_keys) end # Creates a hidden form input field used to transmit data that would be lost due to HTTP's statelessness or actionpack/lib/action_view/helpers/form_tag_helper.rb @@ -190,6 +190,12 @@ class FormTagHelperTest < ActionView::TestCase assert_dom_equal expected, actual end + def test_label_tag_with_symbol + actual = label_tag :title + expected = %(<label for="title">Title</label>) + assert_dom_equal expected, actual + end + def test_label_tag_with_text actual = label_tag "title", "My Title" expected = %(<label for="title">My Title</label>) actionpack/test/template/form_tag_helper_test.rb 2cf161a384cc361d856aa76639bcb30570d67286 Jan De Poorter jan@defv.be http://github.com/rails/rails/commit/7aaf1689dda863b72623f0e52ad87e2b739cb22b 7aaf1689dda863b72623f0e52ad87e2b739cb22b 2008-07-29T04:39:21-07:00 2008-07-29T04:11:38-07:00 Fix that label_tag doesn't take a symbol for a name. [#719 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> 707d94cffa7d4c64e255c49d0826ef39ad41b6d3 Pratik Naik pratiknaik@gmail.com