Skip to content

Commit

Permalink
renderer calls object.to_json when rendering :json => object [#5655 s…
Browse files Browse the repository at this point in the history
…tate:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
  • Loading branch information
dcrec1 authored and josevalim committed Sep 27, 2010
1 parent e677275 commit a56df5b
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 1 deletion.
2 changes: 1 addition & 1 deletion actionpack/lib/action_controller/metal/renderers.rb
Expand Up @@ -71,7 +71,7 @@ def self._write_render_options
end

add :json do |json, options|
json = ActiveSupport::JSON.encode(json, options) unless json.respond_to?(:to_str)
json = json.to_json(options) unless json.respond_to?(:to_str)
json = "#{options[:callback]}(#{json})" unless options[:callback].blank?
self.content_type ||= Mime::JSON
self.response_body = json
Expand Down
13 changes: 13 additions & 0 deletions actionpack/test/controller/render_json_test.rb
Expand Up @@ -9,6 +9,10 @@ def as_json(options={})
hash.except!(*options[:except]) if options[:except]
hash
end

def to_json(options = {})
super :except => [:c, :e]
end
end

class TestController < ActionController::Base
Expand Down Expand Up @@ -49,6 +53,10 @@ def render_json_with_render_to_string
def render_json_with_extra_options
render :json => JsonRenderable.new, :except => [:c, :e]
end

def render_json_without_options
render :json => JsonRenderable.new
end
end

tests TestController
Expand Down Expand Up @@ -109,4 +117,9 @@ def test_render_json_forwards_extra_options
assert_equal '{"a":"b"}', @response.body
assert_equal 'application/json', @response.content_type
end

def test_render_json_calls_to_json_from_object
get :render_json_without_options
assert_equal '{"a":"b"}', @response.body
end
end

0 comments on commit a56df5b

Please sign in to comment.