This repository is private.
All pages are served over SSL and all pushing and pulling is done over SSH.
No one may fork, clone, or view it unless they are added as a member.
Every repository with this icon (
) is private.
Every repository with this icon (
This repository is public.
Anyone may fork, clone, or view it.
Every repository with this icon (
) is public.
Every repository with this icon (
Bruce Krysiak (author)
Mon Dec 08 16:38:04 -0800 2008
commit aa5cdb0d47fb5484bfdde8244df7efeb2175bf3a
tree b0b0309c7f6e700c70e2fbbe3185724479a7434f
parent 96b815d7e81b9cef912ef94c96dca923fe43b0ba
tree b0b0309c7f6e700c70e2fbbe3185724479a7434f
parent 96b815d7e81b9cef912ef94c96dca923fe43b0ba
... |
... |
|
... |
... |
|
... |
... |
|
... |
... |
|












Um, do you know how much code you broke by forcing “dasherize” upon us? I (and plenty of others) are using xml docs that are posted to an action, and taking advantage of the fact that the doc is busted out into a Hash that is added to params.
I have to either figure out how to persuade rails to set :dasherize to false, or go through a couple hundred lines of code and dasherize what I have. Either way, my code will only work on the latest version of rails.
This is a major change, and the default should always be to continue to do whatever was done historically, unless that historic functionality is broken.
My bad, it’s not “dasherize”. The issue is line 223 of hash/conversions.rb – adding “underscore”. Same problem, though, and a major change in functionality.
Sounds like a bug, please file a ticket on lighthouse and assign it to me, ideally with a test case for what’s broken.
We can push out a point release to address this.
Michael,
I created a patch for Hash#from_xml not working with all caps keys due to this commit and assigned it to you. https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/2604