Make dispatcher instances immutable

rails · Apr 15, 2009 · c2511f9 · c2511f9 · alloy · Apr 15, 2009
1 parent d775103
commit c2511f9
Showing 1 changed file with 14 additions and 3 deletions.
diff --git a/actionpack/lib/action_controller/dispatch/dispatcher.rb b/actionpack/lib/action_controller/dispatch/dispatcher.rb
@@ -66,16 +66,27 @@ def cleanup_application
     define_callbacks :prepare_dispatch, :before_dispatch, :after_dispatch
 
     def initialize
-      @app = @@middleware.build(lambda { |env| self.dup._call(env) })
+      @app = @@middleware.build(lambda { |env| self._call(env) })
+      freeze
     end
 
     def call(env)
       @app.call(env)
     end
 
     def _call(env)
-      @env = env
-      dispatch
+      begin
+        run_callbacks :before_dispatch
+        Routing::Routes.call(env)
+      rescue Exception => exception
+        if controller ||= (::ApplicationController rescue Base)
+          controller.call_with_exception(env, exception).to_a
+        else
+          raise exception
+        end
+      ensure
+        run_callbacks :after_dispatch, :enumerator => :reverse_each
+      end
     end
 
     def flush_logger