subtracting blank strings is slightly faster than blank?

rails · Aug 11, 2010 · c8509d5 · yury · Aug 12, 2010 · tenderlove
1 parent 36cb62e
commit c8509d5
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/activerecord/lib/active_record/relation/query_methods.rb b/activerecord/lib/active_record/relation/query_methods.rb
@@ -135,9 +135,7 @@ def build_arel
 
       arel = build_joins(arel, @joins_values) unless @joins_values.empty?
 
-      @where_values.uniq.each do |where|
-        next if where.blank?
-
+      (@where_values - ['']).uniq.each do |where|
         case where
         when Arel::SqlLiteral
           arel = arel.where(where)