Skip to content

Commit

Permalink
just kill brittle test
Browse files Browse the repository at this point in the history
  • Loading branch information
josh committed Mar 24, 2009
1 parent dc88847 commit c919127
Showing 1 changed file with 0 additions and 21 deletions.
21 changes: 0 additions & 21 deletions actionpack/test/controller/session/cookie_store_test.rb
Expand Up @@ -193,27 +193,6 @@ def test_persistent_session_id
end
end

def test_session_store_with_expire_after
app = ActionController::Session::CookieStore.new(DispatcherApp, :key => SessionKey, :secret => SessionSecret, :expire_after => 5.hours)
@integration_session = open_session(app)

with_test_route_set do
# First request accesses the session
cookies[SessionKey] = SignedBar

get '/set_session_value'
assert_response :success
cookie = headers['Set-Cookie']

# Second request does not access the session so the
# expires header should not be changed
get '/no_session_access'
assert_response :success
assert_equal cookie, headers['Set-Cookie'],
"#{unmarshal_session(cookie).inspect} expected but was #{unmarshal_session(headers['Set-Cookie']).inspect}"
end
end

private
def with_test_route_set
with_routing do |set|
Expand Down

1 comment on commit c919127

@knzconnor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it’s not brittle in the way you think it is? We’ve definitely seen some breakages of options being passed down into the rack middleware sessions that are being hard to track down, so cutting tests might not be helping.

Please sign in to comment.