Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Regexp.escape(load_path) in add_routing_namespaces initializer [#4442 …
…state:resolved] Signed-off-by: Michael Koziarski <michael@koziarski.com>
- Loading branch information
d03196c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this have been tested to ensure a regression wouldn't happen?
d03196c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't find any tests involving the string "controller_namespaces". If you point me at an appropriate suite, (which hopefully knows how to run enough of the rails boot sequence to hit this initializer) I'll make a test. Alternately we could pull the initializer's contents out to somewhere more testable, but I don't trust myself yet to do that refactoring properly.