Skip to content

Commit

Permalink
Now that we always return a proxy from mb_chars, even in 1.9, all Str…
Browse files Browse the repository at this point in the history
…ings coming back from AS are UTF-8.
  • Loading branch information
wycats committed May 29, 2010
1 parent e5a56eb commit d7f6f2b
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions actionpack/test/template/text_helper_test.rb
Expand Up @@ -84,8 +84,9 @@ def test_truncate_multibyte
end
else
def test_truncate_multibyte
assert_equal "\354\225\210\353\205\225\355...",
truncate("\354\225\210\353\205\225\355\225\230\354\204\270\354\232\224", :length => 10)
# .mb_chars always returns a UTF-8 String.
# assert_equal "\354\225\210\353\205\225\355...",
# truncate("\354\225\210\353\205\225\355\225\230\354\204\270\354\232\224", :length => 10)

assert_equal "\354\225\204\353\246\254\353\236\221 \354\225\204\353\246\254 ...".force_encoding('UTF-8'),
truncate("\354\225\204\353\246\254\353\236\221 \354\225\204\353\246\254 \354\225\204\353\235\274\353\246\254\354\230\244".force_encoding('UTF-8'), :length => 10)
Expand Down Expand Up @@ -218,7 +219,8 @@ def test_excerpt_with_utf8
else
def test_excerpt_with_utf8
assert_equal("...\357\254\203ciency could not be...".force_encoding('UTF-8'), excerpt("That's why e\357\254\203ciency could not be helped".force_encoding('UTF-8'), 'could', 8))
assert_equal("...\203ciency could not be...", excerpt("That's why e\357\254\203ciency could not be helped", 'could', 8))
# .mb_chars always returns UTF-8, even in 1.9. This is not great, but it's how it works. Let's work this out.
# assert_equal("...\203ciency could not be...", excerpt("That's why e\357\254\203ciency could not be helped".force_encoding("BINARY"), 'could', 8))
end
end

Expand Down

0 comments on commit d7f6f2b

Please sign in to comment.