@@ -134,7 +134,9 @@ module ActiveRecord def update_with_dirty if partial_updates? - update_without_dirty(changed) + # Serialized attributes should always be written in case they've been + # changed in place. + update_without_dirty(changed | self.class.serialized_attributes.keys) else update_without_dirty end activerecord/lib/active_record/dirty.rb @@ -191,6 +191,18 @@ class DirtyTest < ActiveRecord::TestCase assert !pirate.changed? end + def test_save_should_store_serialized_attributes_even_with_partial_updates + with_partial_updates(Topic) do + topic = Topic.create!(:content => {:a => "a"}) + topic.content[:b] = "b" + #assert topic.changed? # Known bug, will fail + topic.save! + assert_equal "b", topic.content[:b] + topic.reload + assert_equal "b", topic.content[:b] + end + end + private def with_partial_updates(klass, on = true) old = klass.partial_updates? activerecord/test/cases/dirty_test.rb 88eec8327b179cd41314e85868879b46bcf2530e Tom Lea contrib@tomlea.co.uk http://github.com/rails/rails/commit/decc9730959de85b4c4873986bcd33e12fa1985d decc9730959de85b4c4873986bcd33e12fa1985d 2008-08-12T09:18:29-07:00 2008-08-11T10:16:58-07:00 Serialized attributes will now always be saved even with partial_updates turned on. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#788 state:committed] f9f33b32f3201ac01604670913166e552ac25565 Michael Koziarski michael@koziarski.com