Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
use autoload instead of explicit requires for ActionMailer
- Loading branch information
Showing
10 changed files
with
63 additions
and
47 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -58,6 +58,7 @@ def assert_no_emails(&block) | |
end | ||
end | ||
|
||
# TODO: Deprecate this | ||
module Test | ||
module Unit | ||
class TestCase | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
# Prefer gems to the bundled libs. | ||
require 'rubygems' | ||
|
||
begin | ||
gem 'text-format', '>= 0.6.3' | ||
rescue Gem::LoadError | ||
$:.unshift "#{File.dirname(__FILE__)}/text-format-0.6.3" | ||
end | ||
|
||
require 'text/format' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
# Prefer gems to the bundled libs. | ||
require 'rubygems' | ||
|
||
begin | ||
gem 'tmail', '~> 1.2.3' | ||
rescue Gem::LoadError | ||
$:.unshift "#{File.dirname(__FILE__)}/tmail-1.2.3" | ||
end | ||
|
||
module TMail | ||
end | ||
|
||
require 'tmail' | ||
|
||
silence_warnings do | ||
TMail::Encoder.const_set("MAX_LINE_LEN", 200) | ||
end |
e201fc7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to comment out “require ‘tmail/net’ in actionmailer/base.rb” to get rails to start after this commit.
e201fc7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
e201fc7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, can’t seem to reproduce the issue. what exception is getting raised?
e201fc7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ActionMailer seems to work without it, interestingly enough.
e201fc7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jeremy just remove the line a few mins ago. It should be fine for now.