Skip to content

Commit

Permalink
Test if test/performance/browsing_test.rb exists when --skip-activere…
Browse files Browse the repository at this point in the history 
…cord is used

[#4104]
  • Loading branch information
@spastorino
spastorino committed Oct 9, 2010
1 parent e695c40 commit e7f911d
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions railties/test/generators/app_generator_test.rb
View file
Expand Up @@ -168,6 +168,7 @@ def test_config_another_database
def test_config_database_is_not_added_if_skip_active_record_is_given
run_generator [destination_root, "--skip-active-record"]
assert_no_file "config/database.yml"
assert_file "test/performance/browsing_test.rb"
end

def test_active_record_is_removed_from_frameworks_if_skip_active_record_is_given
Expand Down

3 comments on commit e7f911d

@asanghi
Copy link
Contributor

@asanghi asanghi commented on e7f911d Oct 9, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still just as confused about this since yesterday, why this particular assertion, mate? :)

@spastorino
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because patches provided here https://rails.lighthouseapp.com/projects/8994/tickets/4104 were creating an empty test/performance dir, so just in case ;)

@asanghi
Copy link
Contributor

@asanghi asanghi commented on e7f911d Oct 9, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Santiago, understood now. Yes, the patches earlier were indeed not correct.

Please sign in to comment.