Make named helpers unprotected without becoming actions [#4696 state:…

…resolved]
rails · Jun 7, 2010 · eebac02 · eebac02
1 parent 3adb395
commit eebac02
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/actionpack/lib/action_controller/metal/url_for.rb b/actionpack/lib/action_controller/metal/url_for.rb
@@ -16,5 +16,13 @@ def _router
       raise "In order to use #url_for, you must include the helpers of a particular " \
             "router. For instance, `include Rails.application.routes.url_helpers"
     end
+
+    module ClassMethods
+      def action_methods
+        @action_methods ||= begin
+          super - _router.named_routes.helper_names
+        end
+      end
+    end
   end
 end
diff --git a/actionpack/lib/action_dispatch/routing/route_set.rb b/actionpack/lib/action_dispatch/routing/route_set.rb
@@ -68,6 +68,10 @@ def initialize
           clear!
         end
 
+        def helper_names
+          self.module.instance_methods.map(&:to_s)
+        end
+
         def clear!
           @routes = {}
           @helpers = []
@@ -176,7 +180,6 @@ def #{selector}(*args)
 
                 url_for(options)
               end
-              protected :#{selector}
             END_EVAL
             helpers << selector
           end