Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Added ability to pass in :public => true to fresh_when, stale?, and e…
…xpires_in to make the request proxy cachable [#2095 state:committed] Signed-off-by: David Heinemeier Hansson <david@loudthinking.com>
- Loading branch information
Showing
3 changed files
with
109 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2a32bd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really terrible - changing :private to :public without any deprecation warning? Not cool.
f2a32bd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a mistake, Spencer. Please raise the issue on Lighthouse ticket #2095.