Skip to content

Commit

Permalink
Rubinious: work around h[k] ||= v returning []= result instead of v
Browse files Browse the repository at this point in the history
  • Loading branch information
jeremy committed Jun 10, 2008
1 parent 19895f0 commit f5cbad2
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 3 deletions.
17 changes: 14 additions & 3 deletions activesupport/lib/active_support/core_ext/enumerable.rb
@@ -1,3 +1,5 @@
require 'active_support/ordered_hash'

module Enumerable
# Ruby 1.8.7 introduces group_by, but the result isn't ordered. Override it.
remove_method(:group_by) if [].respond_to?(:group_by) && RUBY_VERSION < '1.9'
Expand All @@ -18,10 +20,19 @@ module Enumerable
# "2006-02-24 -> Transcript, Transcript"
# "2006-02-23 -> Transcript"
def group_by
inject ActiveSupport::OrderedHash.new do |grouped, element|
(grouped[yield(element)] ||= []) << element
grouped
assoc = ActiveSupport::OrderedHash.new

each do |element|
key = yield(element)

if assoc.has_key?(key)
assoc[key] << element
else
assoc[key] = [element]
end
end

assoc
end unless [].respond_to?(:group_by)

# Calculates a sum from the elements. Examples:
Expand Down
1 change: 1 addition & 0 deletions activesupport/lib/active_support/ordered_hash.rb
Expand Up @@ -12,6 +12,7 @@ def []=(key, value)
else
self << [key, value]
end
value
end

def [](key)
Expand Down

0 comments on commit f5cbad2

Please sign in to comment.