speed up fixtures by not loading all their classes

[grosser]

this took our time for a test with tixtures :all from 28s to 20s

most of the time, only the tables are needed and fixtures :all is just a developer saying "I don't know",
so let's save the complexity and overhead!

people that rely on that can do their own requires or use eager loading in test.rb

@rafaelfranca @tenderlove

[rafaelfranca]

Does it require any adicional step from people that already use fixture :all?

[grosser]

if autoload works: no
if they disabled autoload: maybe ...

[rafaelfranca]

I don't like this:

people that rely on that can do their own requires or use eager loading in test.rb

People will not know why their tests are failing after this change.

[rafaelfranca]

Also if we are trading predictability for speed I prefer to keep the predictability.

cc @fxn @jeremy

[grosser]

people that disabled autoload that is ... so not sure how many % that is
also if you don't use autoload, chances are you require all your things up
front anyway ...
so 1-5% of 1-5% of users will get a 'Undefined class User' when updating
and then have to add a pretty straight forward require 'user'

On Mon, Sep 22, 2014 at 1:31 PM, Rafael Mendonça França <
notifications@github.com> wrote:

I don't like this:

people that rely on that can do their own requires or use eager loading in
test.rb

People will not know why their tests are failing after this change.

—
Reply to this email directly or view it on GitHub
#17014 (comment).

[jeremy]

👍 We already look up model classes by constantizing anyway.

As far as I can tell, requiring them here predates that, so we're doing duplicate work now.

[grosser]

FYI monkeypatch in case you want to try it out:

# do not load every class when using fixtures :all -> speedup
ActiveRecord::TestFixtures::ClassMethods.class_eval do
 def require_fixture_classes(*args)
 end
end

[tenderlove]

@rafaelfranca as @jeremy points out, the autoload will get fired anyhow since we do a constant lookup, so this code just seems like extra work.

[grosser]

fixed the tests, good to merge ?

[grosser]

@tenderlove / @jeremy merge ?

[tenderlove]

@grosser THANKS! <3<3<3<3 :-D