Add ActiveRecord::Relation#or description to guides #29225
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @matthewd (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
| and passing the second one as an argument. | ||
|
|
||
| ```ruby | ||
| Client.where(locked: true).or(Client.where(orders_count: [1,2,5])) |
There was a problem hiding this comment.
Generated SQL is clients.orders_count IN (1,3,5) but the condition is Client.where(orders_count: [1,2,5]).
There was a problem hiding this comment.
Thx. I've amended the fix.
|
Thanks! |
Summary
In guides, I couldn't find any place where AcitveRecord::Relation#or is described.
I prepared a short description with an example to be merged to docs.
Other information
#16052